feat: subqueries in Project#23039
Open
zyuiop wants to merge 2 commits into
Open
Conversation
this fixes an issue where mark joins "lose" the qualifier after optimize_projections in EXISTS subqueries. Indeed, in EXISTS subqueries, we don't need any projected field, so optimize_projections remove them all, which makes it impossible for build_join_schema to know what qualifier to use for the mark field
github-actions
Bot
added
logical-expr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
This contains two changes (which we can possibly split, I'll let reviewers judge).
decorrelate_predicate_subquery: if the plan is a Projection, we transform the sub-query into a Mark Joinbuild_join_schemato use LogicalPlan as input: this is required because optimize_projections remove all fields from the TableScan in the mark join, which in turns makes it impossible formark_fieldto determine the table reference to use for the mark fieldAre these changes tested?
Yes
Are there any user-facing changes?
Yes,
build_join_schema's signature has changed.api change